Remove assert for alibi in case of FusedSDPA. #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaraban
force-pushed
the
fix_fused_main
branch
3 times, most recently
from
b940234 to
faa0f6a
Compare
itaraban
force-pushed
the
fix_fused_main
branch
2 times, most recently
from
bf62a27 to
d732bbe
Compare
michalkuligowski
requested changes
Dec 9, 2024
| @@ -212,8 +209,7 @@ def _compile_region(self, model, name, module): | |||
|
|
|||
| def _set_attn_bias(self, attn_metadata, batch_size, seq_len, device, | |||
| dtype): | |||
| if (attn_metadata is None or self.prefill_use_fusedsdpa | |||
| or not attn_metadata.is_prompt): | |||
| if (attn_metadata is None or not attn_metadata.is_prompt): | |||
There was a problem hiding this comment.
Why did you remove prefill_use_fusedsdpa here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.